[virt-tools-list] virtinst-0.500.6 question, clean build environment issues

Cole Robinson crobinso at redhat.com
Tue Jul 12 14:23:30 UTC 2011


On 07/08/2011 05:26 PM, Richard W.M. Jones wrote:
> On Fri, Jul 08, 2011 at 02:17:08PM -0700, Jason Helfman wrote:
>> Right. Here is a link to the current bsd.port.mk file.
>> http://www.freebsd.org/cgi/cvsweb.cgi/ports/Mk/bsd.port.mk?rev=1.687;content-type=text%2Fx-cvsweb-markup
> 
> It appears to run:
> 
>   pkg_delete -f $name
> 
> and pkg_delete (according to [1]) looks very much like RPM and other
> packaging tools, ie. sensible.
> 
> However I'm not any closer to understanding why those locale files
> would be deleted after the deinstall.  It appears to be some
> interaction between the pkg_* tools and files that virt-install
> modifies, but in what way I don't know.
> 
> Rich.
> 
> [1] http://www.freebsd.org/cgi/man.cgi?query=pkg_delete&sektion=1
> 

Thanks for looking into it Rich, doesn't make much sense to me either,
nothing in the virtinst build process seems to be touching those files.

Jason, does applying the following patch to virtinst make any difference
(it just disables all .po building and installing). If not, something
must be funky on the bsd side, otherwise maybe some side effect of the
po commands we run is causing the bsd package tool to prune those files
on uninstall?

Thanks,
Cole

diff --git a/setup.py b/setup.py
index 659ddd4..c708bdc 100755
--- a/setup.py
+++ b/setup.py
@@ -277,6 +277,7 @@ class build(_build):
         if not os.path.exists("build/po"):
             os.makedirs("build/po")

+        """
         for filename in glob(pjoin(os.getcwd(), 'po', '*.po')):
             filename = os.path.basename(filename)
             lang = os.path.basename(filename)[0:len(filename) - 3]
@@ -286,6 +287,7 @@ class build(_build):

             print "Building %s from %s" % (newname, filename)
             os.system("msgfmt po/%s -o %s" % (filename, newname))
+        """

         _build.run(self)
         builddir = self.build_lib
@@ -317,6 +319,7 @@ class install_data(_install_data):
     """ custom install_data command to prepare i18n files for install"""

     def run(self):
+        """
         dirlist = os.listdir("build/po")
         for lang in dirlist:
             if lang != "." and lang != "..":
@@ -329,6 +332,7 @@ class install_data(_install_data):

                 # Add these to the datafiles list
                 datafiles.append(toadd)
+        """
         _install_data.run(self)

 setup(name='virtinst',




More information about the virt-tools-list mailing list