[virt-tools-list] [libosinfo] Correct a typo in all XML files
Daniel P. Berrange
berrange at redhat.com
Fri Jun 17 14:15:18 UTC 2011
On Thu, Jun 16, 2011 at 06:42:55PM +0300, Zeeshan Ali wrote:
> From: "Zeeshan Ali (Khattak)" <zeeshanak at gnome.org>
>
> ---
> data/oses/debian.xml | 6 +++---
> data/oses/fedora.xml | 8 ++++----
> data/oses/generic-linux.xml | 4 ++--
> data/oses/mandriva.xml | 8 ++++----
> data/oses/rhel.xml | 10 +++++-----
> data/oses/suse.xml | 4 ++--
> data/oses/ubuntu.xml | 4 ++--
> 7 files changed, 22 insertions(+), 22 deletions(-)
>
> diff --git a/data/oses/debian.xml b/data/oses/debian.xml
> index a14ac14..17981e7 100644
> --- a/data/oses/debian.xml
> +++ b/data/oses/debian.xml
> @@ -15,8 +15,8 @@
> <upgrades id="http://debian.org/etch"/>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> @@ -28,7 +28,7 @@
> <upgrades id="http://debian.org/lenny"/>
>
> <devices>
> - <device id="http://www.linux-usb.org/usb.ids/80ee/0021">
> + <device id="http://www.linux-usb.org/usb.ids/80ee/0021"/>
> </devices>
> </os>
>
> diff --git a/data/oses/fedora.xml b/data/oses/fedora.xml
> index 57281de..73f1dc1 100644
> --- a/data/oses/fedora.xml
> +++ b/data/oses/fedora.xml
> @@ -39,10 +39,10 @@
> <upgrades id="http://fedoraproject.org/fedora/8"/>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> <!-- Apparently F9 has selinux errors when installing with virtio:
> https://bugzilla.redhat.com/show_bug.cgi?id=470386
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> -->
> </devices>
> </os>
> @@ -55,7 +55,7 @@
> <upgrades id="http://fedoraproject.org/fedora/9"/>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> @@ -67,7 +67,7 @@
> <upgrades id="http://fedoraproject.org/fedora/10"/>
>
> <devices>
> - <device id="http://www.linux-usb.org/usb.ids/80ee/0021">
> + <device id="http://www.linux-usb.org/usb.ids/80ee/0021"/>
> </devices>
> </os>
>
> diff --git a/data/oses/generic-linux.xml b/data/oses/generic-linux.xml
> index dec6e0c..3b9d568 100644
> --- a/data/oses/generic-linux.xml
> +++ b/data/oses/generic-linux.xml
> @@ -21,8 +21,8 @@
> <vendor>Linux Kernel Developers</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> diff --git a/data/oses/mandriva.xml b/data/oses/mandriva.xml
> index 5984cf0..4118128 100644
> --- a/data/oses/mandriva.xml
> +++ b/data/oses/mandriva.xml
> @@ -14,8 +14,8 @@
> <vendor>Mandriva</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> @@ -33,8 +33,8 @@
> <vendor>Mandriva</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> diff --git a/data/oses/rhel.xml b/data/oses/rhel.xml
> index 1d96a37..a8458f1 100644
> --- a/data/oses/rhel.xml
> +++ b/data/oses/rhel.xml
> @@ -43,8 +43,8 @@
> <vendor>Red Hat, Inc</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> @@ -63,9 +63,9 @@
> <vendor>Red Hat, Inc</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> - <device id="http://www.linux-usb.org/usb.ids/80ee/0021">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> + <device id="http://www.linux-usb.org/usb.ids/80ee/0021"/>
> </devices>
> </os>
>
> diff --git a/data/oses/suse.xml b/data/oses/suse.xml
> index 496a25e..0f9bcb0 100644
> --- a/data/oses/suse.xml
> +++ b/data/oses/suse.xml
> @@ -14,8 +14,8 @@
> <vendor>Novell</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
> diff --git a/data/oses/ubuntu.xml b/data/oses/ubuntu.xml
> index 5141505..22ba801 100644
> --- a/data/oses/ubuntu.xml
> +++ b/data/oses/ubuntu.xml
> @@ -7,7 +7,7 @@
> <vendor>Canonical</vendor>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1000"/>
> </devices>
> </os>
>
> @@ -27,7 +27,7 @@
> <upgrades id="http://ubuntu.com/intrepid"/>
>
> <devices>
> - <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001">
> + <device id="http://pciids.sourceforge.net/v2.2/pci.ids/1af4/1001"/>
> </devices>
> </os>
>
ACK
It would be good to add a 'make check' rule in data/Makefile.am that
runs 'xmllint' across all the files as a sanity check
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the virt-tools-list
mailing list