[virt-tools-list] [PATCH 02/10] Modified libvirtwork to use vmmNetwork objects.

Darryl L. Pierce dpierce at redhat.com
Tue May 31 17:29:31 UTC 2011


On Tue, May 31, 2011 at 12:55:18PM -0400, Cole Robinson wrote:
> > -        result = self.__conn.networkLookupByName(name)
> > -        if result is None: raise Exception("No such network exists: %s" % name)
> > +        result = self.__vmmconn.get_net(uuid)
> > +        if result is None: raise Exception("No such network exists: uuid=%s" % uuid)
> >  
> 
> get_net won't ever return None, it will throw it's own exception. That
> can be a follow up though.
> 
> ACK to the series, I've pushed it now.

KK - I'll make a note to go back and re-address that case. Thanks for
the push. :)

-- 
Darryl L. Pierce, Sr. Software Engineer @ Red Hat, Inc.
Delivering value year after year.
Red Hat ranks #1 in value among software vendors.
http://www.redhat.com/promo/vendor/

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20110531/82650e9e/attachment.sig>


More information about the virt-tools-list mailing list