[virt-tools-list] [PATCH virt-viewer 2/4] remote-viewer: make it a GUI/windows application with hybrid console

[Christophe Fergeau]

On Mon, Apr 02, 2012 at 11:57:00PM +0200, Marc-André Lureau wrote:
> If the application can attach to its parent console, redirect
> input/output. So that will work nicely with the command line wrapper.
> ---
>  src/Makefile.am          |    1 +
>  src/remote-viewer-main.c |   15 +++++++++++++++
>  2 files changed, 16 insertions(+), 0 deletions(-)
> 
> diff --git a/src/Makefile.am b/src/Makefile.am
> index d47cc09..283733f 100644
> --- a/src/Makefile.am
> +++ b/src/Makefile.am
> @@ -87,6 +87,7 @@ remote_viewer_SOURCES =				\
>  	remote-viewer-main.c			\
>  	$(NULL)
>  remote_viewer_LDFLAGS =				\
> +	-Wl,--subsystem,windows			\

This breaks linux builds here (fedora 17). This patch helps:

diff --git a/src/Makefile.am b/src/Makefile.am
index 283733f..47b97b6 100644
--- a/src/Makefile.am
+++ b/src/Makefile.am
@@ -87,11 +87,15 @@ remote_viewer_SOURCES =                             \
        remote-viewer-main.c                    \
        $(NULL)
 remote_viewer_LDFLAGS =                                \
-       -Wl,--subsystem,windows                 \
        $(GLIB2_LIBS)                           \
        $(GTK_LIBS)                             \
        $(LIBXML2_LIBS)                         \
        $(NULL)
+
+if OS_WIN32
+remote_viewer_LDFLAGS += -Wl,--subsystem,windows
+endif
+
 remote_viewer_CFLAGS =                         \
        -DLOCALE_DIR=\""$(datadir)/locale"\"    \
        $(GLIB2_CFLAGS)                         \

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20120403/92376498/attachment.sig>