[virt-tools-list] [PATCH 1/2] install script: generates the output in a file

Zeeshan Ali (Khattak) zeeshanak at gnome.org
Mon Aug 13 19:46:06 UTC 2012


On Mon, Aug 13, 2012 at 9:05 PM, Christophe Fergeau <cfergeau at redhat.com> wrote:
> On Mon, Aug 13, 2012 at 08:54:30PM +0300, Zeeshan Ali (Khattak) wrote:
>> > +
>> > +    if (data->output_pos < data->output_len) {
>> > +        g_output_stream_write_async(G_OUTPUT_STREAM (data->stream),
>> > +                                    data->output + data->output_pos,
>> > +                                    data->output_len - data->output_pos,
>> > +                                    G_PRIORITY_DEFAULT,
>> > +                                    data->cancellable,
>> > +                                    osinfo_install_script_generate_output_write_file,
>> > +                                    data);
>>
>> Same with these arguments.
>>
>> > +
>> > +    } else {
>> > +        g_output_stream_close_async(G_OUTPUT_STREAM (data->stream),
>> > +                                    G_PRIORITY_DEFAULT,
>> > +                                    data->cancellable,
>> > +                                    osinfo_install_script_generate_output_close_file,
>> > +                                    data);
>>
>> And here. Finding and correcting the rest of unaligned arguments is
>> left as home work. :)
>>
>
> I haven't applied the patch to a tree to see how this looks like, but the
> arguments are aligned as expected in my mailer.

Thanks for pointing out! Keep forgetting gmail tries to be smart. :(


-- 
Regards,

Zeeshan Ali (Khattak)
FSF member#5124




More information about the virt-tools-list mailing list