[virt-tools-list] [PATCH v2 4/7] Add VirtViewerFile

Christophe Fergeau cfergeau at redhat.com
Mon Dec 3 12:54:20 UTC 2012

On Mon, Dec 03, 2012 at 01:10:19PM +0100, Marc-André Lureau wrote:
> Hi
> On Mon, Dec 3, 2012 at 10:53 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:
> > Just one small comment, tls-ciphers could probably be a GStrv (mentioning
> > it as disable-effects and encrypted-channels are GStrv). ACK either way.
> >
> That's an interesing point:
> SSL_CTX_set_cipher_list() is expecting a string, and is described as "The
> cipher list consists of one or more cipher strings separated by colons" in
> ciphers(1)
> Spice-gtk expects a string property too. I was afraid the ; may return only
> the first string, so I verified the KeyFile parser handles a string value
> with ; in it correctly.

You confused me now, you start by mentioning colons (ie ':') and then
you talk about testing ';'. Is there some kind of mismatch between
controller values and SSL_CTX_set_cipher_list?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121203/20b1a6a4/attachment.sig>

More information about the virt-tools-list mailing list