[virt-tools-list] [PATCH virt-viewer] Use monitor geometry, not screen size

Marc-André Lureau mlureau at redhat.com
Fri Dec 7 13:18:25 UTC 2012


----- Mensaje original -----
> My reasoning was that gtk_widget_get_screen(GTK_WIDGET(self));
> operates on
> a subwindow of the application, not on the main one, so it's
> inconsistent
> with the use of _get_root_window. I don't think this will cause


> practical
> problems, but I thought I'd asked anyway.
> Also, is _get_root_window about getting the main GdkWindow for the
> current
> GtkWindow, or about the screen root GdkWindow? I guess the former,
> but I'm

There are two functions ...get_root_window, one is for the screen (screen_get_root_window) and one if for the widget/window hierarchy (widget_get_root_window)

> a bit confused.  Anyway, ACK from me if you think _get_root_window is
> better.

So my understanding is that widget_get_root_window() will get us to the top-level window containing the widget. Hence, I still think the patch is correct for the reason given before.

More information about the virt-tools-list mailing list