[virt-tools-list] [PATCH virt-viewer 0/9] Add customizable key bindings

Marc-André Lureau marcandre.lureau at gmail.com
Mon Feb 20 19:56:16 UTC 2012


On Wed, Feb 15, 2012 at 1:42 AM, Marc-André Lureau
<marcandre.lureau at gmail.com> wrote:
> On Wed, Feb 15, 2012 at 1:29 AM, Marc-André Lureau
> <marcandre.lureau at gmail.com> wrote:
>> Gtk+ requirement bump to 2.16 is supported by RHEL5
>> (needed for various accelgroup code).
>
> That's actually incorrect. I knew I had to double check that.

I worked on a patch to support < gtk 2.14 for the part I added, and I
figured we actually use symbols from 2.18:

virt-viewer-app.c: In function 'count_window_visible':
virt-viewer-app.c:220: warning: implicit declaration of function
'gtk_widget_get_visible'
virt-viewer-app.c:220: warning: nested extern declaration of
'gtk_widget_get_visible'
virt-viewer-app.c: In function 'virt_viewer_app_bell':
virt-viewer-app.c:888: warning: implicit declaration of function
'gtk_widget_get_window'
virt-viewer-app.c:888: warning: nested extern declaration of
'gtk_widget_get_window'
virt-viewer-app.c:888: warning: passing argument 1 of
'gdk_window_beep' makes pointer from integer without a cast


Should we just bump gtk deps to 2.18?

Then the patch series can be reviewed in its current form.

regards

-- 
Marc-André Lureau
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Add-compatibility-code-for-GTK-2.14.patch
Type: text/x-patch
Size: 3615 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20120220/c3a0f7c3/attachment.bin>


More information about the virt-tools-list mailing list