[virt-tools-list] [PATCH virt-viewer 5/7] Add VirtViewerSession:file property

Marc-André Lureau marcandre.lureau at gmail.com
Tue Nov 27 13:01:14 UTC 2012


On Tue, Nov 27, 2012 at 10:45 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:

> A bit confused by the commit log, use of the file to define the connection
> parameters is done in the next commit. The 'Also' is a clear hint that this
> commit should be split, and it would have been nice to explain why this
> mime type is needed in the log.
>

Maybe I should stop using "also" in my commit messages!

I don't think it should be split, if the session has a file, it means we
need to save to recent with that file and its correct mime.

-- 
Marc-André Lureau
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121127/a212dad4/attachment.htm>


More information about the virt-tools-list mailing list