[virt-tools-list] [PATCH virt-viewer 6/7] spice: learn to connect from file

Christophe Fergeau cfergeau at redhat.com
Tue Nov 27 13:18:36 UTC 2012


On Tue, Nov 27, 2012 at 01:59:14PM +0100, Marc-André Lureau wrote:
> Hi
> 
> On Tue, Nov 27, 2012 at 10:49 AM, Christophe Fergeau <cfergeau at redhat.com>wrote:
> 
> > Nit: this 'app' variable could go in the if (file){} block
> 
> 
> I am not convinced that change is really worth it here, I'll keep it that
> way if you don't mind.

I don't mind at all. I tend to keep local variables in the smallest block
possible as this makes it much easier to know when it's relevant and when
it's not relevant.

Christophe
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20121127/676d33b1/attachment.sig>


More information about the virt-tools-list mailing list