[virt-tools-list] [PATCH 1/2] update autobuild.sh so it works

Cole Robinson crobinso at redhat.com
Fri Apr 5 14:33:43 UTC 2013


On 04/04/2013 04:48 PM, Daniel P. Berrange wrote:
> On Thu, Apr 04, 2013 at 03:15:38PM -0400, Cole Robinson wrote:
>> On 04/04/2013 12:49 PM, Daniel P. Berrange wrote:
>>> On Thu, Apr 04, 2013 at 12:41:30PM -0400, Gene Czarcinski wrote:
>>>> There a some problems with autobuild.sh and this patch addresses
>>>> them:
>>>>
>>>> 1. Some of the tests fail so temporarily comment out
>>>> "prython setup.py test" until things are fixed so the tests
>>>> run correctly.  At that time, this should be uncommented.
>>>>
>>>> 2. "python setup.py install" needs to use --root= instead
>>>> of --prefix=
>>>>
>>>> 3. For the rpmbuild, use dist/*tar.gz instead of *.tar.gz
>>>>
>>>> 4. "python setup.py build" modifies the git tracked/managed
>>>> file po/virt-manager.pot so that you end of with uncommitted
>>>> changes.  To correct this: use the sdist created tarball,
>>>> expand it into a local/unmangerd directory and run build,
>>>> test, and install out of this directory.
>>>
>>> Actually the right fix there is to just remove virt-manager.pot
>>> from GIT entirely. GIT shouldn't be used to track any files
>>> which are purely auto-generated, as the .pot file is. Only the
>>> .po files need to be in GIT
>>>
>>
>> Transifex requires the pot file to be in tree at least, there's a bit about it
>> here:
> 
> Ah, well i guess it depends how you use transifex :-) For other projects
> I don't ever let Transifex have any repo access. I just use 'tx push' to
> send the updated pot file to transifex when required, and 'tx pull' to
> bring down the .po's later.
> 

Oh, hmm, didn't realize that's an option, i'll consider it. And it doesn't
really require giving access to the git repo, you just tell transifex the
gitweb/cgit link to the pot file.

- Cole




More information about the virt-tools-list mailing list