[virt-tools-list] [PATCH 1/2] virt-viewer-display-spice: Pass proper x and y coordinates for monitors

[Marc-André Lureau]

Hi

----- Mensaje original -----
> >> +        x = monitor.x;
> >> +        y = monitor.y;
> >>           dw = monitor.width;
> >>           dh = monitor.height;
> >
> > It clearly makes sense in fullscreen / monitor.
> 
> Yes, note I think we should also set disable-display-align to false
> when
> going fullscreen after this patch, since this clearly gives us
> better monitor coordinates then the align algorithm will. Esp when
> using setups with 4 monitors arranged in a 2x2 grid, etc. (not all
> that crazy when you look at trading rooms for stock exchanges, etc.).
> 
> I'll write a patch for this.

You are right on this.

> 
> > However, I really don't think it's a good idea to reorder monitors
> > depending on their window position, even if it may be funny, just
> > 5 sec. ;)
> 
> 
> IE: Take a setup with a laptop and a monitor right of the laptop,
> with the monitor being used as the primary screen. Now the user
> starts
> remote-viewer on the primary screen, getting display 1 there. Then he
> opens a second display and moves that to the laptop (which is left
> of the monitor).
> 
> Now the display windows are arranged right (monitor, display 1) to
> left
> (laptop, display2). But in the vm they will be arranged left to
> right.

Yes, in window mode, I think that's what we should keep doing: not reordering guest monitors merely based on the fact of their respective window positions on the client.
 
> Until the user goes fullscreen, when we all of a sudden do the right
> thing. So not only is this counter intuitive. it will also cause
> inconsistencies between windowed and fullscreen mode monitor
> arrangement inside the guest.

In fullscreen, there is no notion of individual window. The client doesn't have a floating window he can identify by its content.