[virt-tools-list] [virt-manager][PATCH 3/3] Update man page author section.

[Leonardo Augusto Guimarães Garcia]

On 07/10/2013 02:03 PM, Cole Robinson wrote:
> Thanks, I pushed the first two. But see below.
>
> On 07/10/2013 12:14 PM, Leonardo Garcia wrote:
>> From: Leonardo Garcia <lagarcia at br.ibm.com>
>>
>> ---
>>   man/virt-manager.pod |    2 +-
>>   1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/man/virt-manager.pod b/man/virt-manager.pod
>> index f8e4d4b..a33955e 100644
>> --- a/man/virt-manager.pod
>> +++ b/man/virt-manager.pod
>> @@ -85,7 +85,7 @@ Standard GTK options like --g-fatal-warnings are also accepted.
>>   
>>   =head1 AUTHOR
>>   
>> -Written by Daniel P. Berrange and Cole Robinson.
>> +Written by Daniel P. Berrange, Cole Robinson, and Leonardo Garcia.
>>   
>>   =head1 BUGS
>>   
> I always took this to mean 'virt-manager authors' and not specifically 'man
> page authors', but it appears there's examples of both in the wild. It's tough
> to do lists like this without overlooking someone or creating maintenance
> burden. My recommendation for this in order is:
Hehe, I always thought that patches including the patch's author name in 
an AUTHOR section or in an AUTHORS file were a little bit petulant. :)

Sorry that I could not resist this time. In fact, I agree with you that 
the AUTHOR section should mean 'virt-manager authors'. In this case I 
got a little bit confused because looking in the man page change 
history, I could only find you and Daniel making changes on the file, 
while we have many others contributing to virt-manager. However, to be 
very honest here, you both have done the majority of the work in 
virt-manager and, because of that, deserve to have your names listed in 
the AUTHOR section.

That said, I think we can just stay where we are. :)

Best regards,

Leonardo Garcia
>
> 1) Drop the AUTHORS section from every man page
> 2) Clarify the AUTHORS section from each man page to mean 'application
> authors', drop all hardcoded names, and say 'see the git log' or provide a
> link to cgit.
> 3) Clarify that this is 'man page authors' Be fair and do some git archaeology
> to determine every person that has touched these files and list them all (I
> actually won't take a patch for this, just listing it for completeness).
>
> - Cole
>