[virt-tools-list] [PATCH] usbredir: Don't depend on channel ordering

Guannan Ren gren at redhat.com
Fri Jun 28 10:04:12 UTC 2013


On 06/28/2013 03:06 AM, Hans de Goede wrote:
> Before this patch-set virt-viewer was calling spice_session_has_channel_type(
> session, SPICE_CHANNEL_USBREDIR) from the session-initialized signal handler,
>
> So as soon as the display channel gets added to the session, the check was
> done. This causes the check to return FALSE for usbredir capable vms if
> the usbredir channel(s) get added to the session after the display channed.
>
> This patch refactors things to not depend on channel creation order.
>
> Signed-off-by: Hans de Goede <hdegoede at redhat.com>
> ---
>   src/virt-viewer-app.c           | 18 +++++++++++++-----
>   src/virt-viewer-session-spice.c | 28 +++++++++++++++-------------
>   src/virt-viewer-session.c       | 39 ++++++++++++++++++++++++++++++++-------
>   src/virt-viewer-session.h       |  5 +++--
>   4 files changed, 63 insertions(+), 27 deletions(-)
>

This patch fixed my issue.
And I noticed that you committed b85ca792 in spice-gtk which makes 
spice_channel_string_to_type public. This works well too.
 >>> SpiceClientGLib.Channel.string_to_type('usbredir')
9
Thanks for both. It's time to send my v3 patch for virt-manager.

Guannan




More information about the virt-tools-list mailing list