[virt-tools-list] [PATCH] virt-install: don't fail on storage pools without targets.

Cole Robinson crobinso at redhat.com
Tue Mar 26 22:01:19 UTC 2013


On 03/25/2013 10:21 PM, Tom Lanyon wrote:
> Hi list,
> 
> Not sure what is your preferred method to receive patches.  See attached
> for a minor bug fix, also available at:
>   https://github.com/tomlanyon/python-virtinst/commit/bad518b15dd5b4858f4fb99837ce54b30f1bcfb6
> 
> This fixes a failure when using CLI virt-install (and potentially virtinst
> in other places) when libvirt is configured with storage pools which have
> no <target> elements; an example of this is the 'rbd' pool type.
> 

Hi Tom, thanks for the patch, it looks fine. Can you please resend it either
using git send-email, or attach the output of git format-patch, which will
ensure your authorship is properly attributed.

Can you also provide an example rbd pool definition so I can unit test this?

Thanks,
Cole




More information about the virt-tools-list mailing list