[virt-tools-list] [PATCH virt-viewer] remote-viewer: set auto-conf before fullscreen

Hans de Goede hdegoede at redhat.com
Fri May 3 19:15:49 UTC 2013


ACK.

On 05/03/2013 06:56 PM, Marc-André Lureau wrote:
> If a monitor is already in fullscreen, setting auto-conf to true will
> not move it until it is re-fullscreen
>
> This was unnoticed, because usually, the first client window is opened
> on the first monitor. Also we may argue than relying on g_object_set()
> property order is lame and fragile, we better split it in two seperate
> calls as this might break upstream.
>
> https://bugzilla.redhat.com/show_bug.cgi?id=872288
> ---
>   src/remote-viewer-main.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
>
> diff --git a/src/remote-viewer-main.c b/src/remote-viewer-main.c
> index daa174f..adc234e 100644
> --- a/src/remote-viewer-main.c
> +++ b/src/remote-viewer-main.c
> @@ -299,10 +299,8 @@ main(int argc, char **argv)
>           goto cleanup;
>
>       app = VIRT_VIEWER_APP(viewer);
> -    g_object_set(app,
> -                 "fullscreen", fullscreen,
> -                 "fullscreen-auto-conf", fullscreen_auto_conf,
> -                 NULL);
> +    g_object_set(app, "fullscreen-auto-conf", fullscreen_auto_conf, NULL);
> +    g_object_set(app, "fullscreen", fullscreen, NULL);
>       virt_viewer_window_set_zoom_level(virt_viewer_app_get_main_window(app), zoom);
>       virt_viewer_app_set_direct(app, direct);
>       virt_viewer_app_set_hotkeys(app, hotkeys);
>




More information about the virt-tools-list mailing list