[virt-tools-list] [PATCH virt-viewer] Do not restrict disabling display to != 0

[Hans de Goede]

Hi,

Good to see this weird special handling of display 0 go away, ACK!

Regards,

Hans


On 05/09/2013 12:58 PM, Marc-André Lureau wrote:
> Virt-viewer hides the display window 0, but doesn't disable the display.
> This is inconsistent with other displays, and prevent the guest OS from
> reconfiguring the main display.
>
> (for monitor 0 to be really disabled in multi-monitor guest, the agent
> need to support sparse monitor config. If not, the first display windows
> will be reopened to match the new un-sparse configuration)
>
> Note also the current Linux vdagent crashes when disabling 1st monitor,
> to be solved seperately.
>
> Related bug:
> https://bugzilla.redhat.com/show_bug.cgi?id=958550
> ---
>   src/virt-viewer-window.c | 6 +-----
>   1 file changed, 1 insertion(+), 5 deletions(-)
>
> diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
> index ab72a6b..c9e1ada 100644
> --- a/src/virt-viewer-window.c
> +++ b/src/virt-viewer-window.c
> @@ -1183,11 +1183,7 @@ virt_viewer_window_hide(VirtViewerWindow *self)
>
>       if (self->priv->display) {
>           VirtViewerDisplay *display = self->priv->display;
> -        guint nth;
> -
> -        g_object_get(display, "nth-display", &nth, NULL);
> -        if (nth != 0)
> -            virt_viewer_display_set_enabled(display, FALSE);
> +        virt_viewer_display_set_enabled(display, FALSE);
>       }
>   }
>
>