[virt-tools-list] [virt-viewer PATCH] Remove non-functional VIRT_VIEWER_HIDE env behavior

Marc-André Lureau mlureau at redhat.com
Thu Nov 21 09:06:20 UTC 2013


ack

----- Original Message -----
> VIRT_VIEWER_HIDE could be set as an environment variable to (theoretically)
> hide
> displays whenever they were not ready.  Unfortunately, this bit of
> functionality
> appears bitrotten and doesn't work anymore (it prevents windows from opening
> when you click 'view > displays > display 2', for instance).  The previous
> patch
> solves this issue a slightly different way, so this particular bit shouldn't
> be
> necessary anymore, even if it did work.
> ---
>  src/virt-viewer-app.c | 3 ---
>  1 file changed, 3 deletions(-)
> 
> diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
> index 487217e..9eff696 100644
> --- a/src/virt-viewer-app.c
> +++ b/src/virt-viewer-app.c
> @@ -803,9 +803,6 @@ display_show_hint(VirtViewerDisplay *display,
>          virt_viewer_notebook_show_display(nb);
>          virt_viewer_window_show(win);
>      } else {
> -        if (win != self->priv->main_window &&
> -            g_getenv("VIRT_VIEWER_HIDE"))
> -            virt_viewer_window_hide(win);
>          if (!self->priv->kiosk)
>              virt_viewer_notebook_show_status(nb, _("Waiting for display
>              %d..."), nth + 1);
>      }
> --
> 1.8.3.1
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
> 




More information about the virt-tools-list mailing list