[virt-tools-list] [virt-manager PATCH 1/3] add new button to remove CPU feature

[Giuseppe Scrivano]

Chen Hanxiao <chenhanxiao at cn.fujitsu.com> writes:

> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
> If we click button 'Copy host CPU Configuration',
> we can hardly get rid of it or delete them manually.
> This patch will add a button
> named 'Clear CPU Configuration' to do this,
> if we want to use the default CPU or host cpu config
> could not start VM.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  ui/details.ui | 14 +++++++++++---
>  1 file changed, 11 insertions(+), 3 deletions(-)
>
> diff --git a/ui/details.ui b/ui/details.ui
> index 88ad9e1..6e1069c 100644
> --- a/ui/details.ui
> +++ b/ui/details.ui
> @@ -2115,7 +2114,13 @@
>                                                      <property name="visible">True</property>
>                                                      <property name="can_focus">False</property>
>                                                      <child>
> -                                                      <placeholder/>
> +                                                      <object class="GtkButton" id="cpu-clear">
> +                                                        <property name="label" translatable="yes">Clear CPU configuration</property>
> +                                                        <property name="visible">True</property>
> +                                                        <property name="can_focus">True</property>
> +                                                        <property name="receives_default">True</property>
> +                                                        <signal name="clicked" handler="on_cpu_clear_clicked" swapped="no"/>
> +                                                      </object>
>                                                      </child>
>                                                    </object>
>                                                    <packing>
> @@ -2124,6 +2129,9 @@
>                                                      <property name="position">1</property>
>                                                    </packing>
>                                                  </child>
> +                                                <child>
> +                                                  <placeholder/>
> +                                                </child>
>                                                </object>
>                                                <packing>
>                                                  <property name="left_attach">1</property>

could you amend this hunk?  It avoids that the new button becomes much
bigger (and not look nice) if you resize the window.


diff --git a/ui/details.ui b/ui/details.ui
index 6e1069c..05cfdb9 100644
--- a/ui/details.ui
+++ b/ui/details.ui
@@ -2124,7 +2124,7 @@
                                                     </child>
                                                   </object>
                                                   <packing>
-                                                    <property name="expand">True</property>
+                                                    <property name="expand">False</property>
                                                     <property name="fill">True</property>
                                                     <property name="position">1</property>
                                                   </packing>

Thanks,
Giuseppe