[virt-tools-list] [RFC PATCH 3/6] virtinstall: add missing OSes

[Giuseppe Scrivano]

"Daniel P. Berrange" <berrange at redhat.com> writes:

> On Tue, Oct 15, 2013 at 08:45:35AM +0200, Christophe Fergeau wrote:
>> Hey,
>> 
>> On Mon, Oct 14, 2013 at 11:16:39PM +0200, Giuseppe Scrivano wrote:
>> > Some OS are not present in libosinfo, add them.
>> > 
>> > Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> > ---
>> >  virtinst/osdict.py | 15 +++++++++++++++
>> >  1 file changed, 15 insertions(+)
>> > 
>> > diff --git a/virtinst/osdict.py b/virtinst/osdict.py
>> > index 3bb59b9..481d5db 100644
>> > --- a/virtinst/osdict.py
>> > +++ b/virtinst/osdict.py
>> > @@ -457,3 +457,18 @@ oslist = db.get_os_list()
>> >  for os in range(oslist.get_length()):
>> >      osi = _OsVariantOsInfo(oslist.get_nth(os))
>> >      _allvariants[osi.name] = osi
>> > +
>> > +# ADD MISSING OSes
>> > +_add_var("generic24", "Generic 2.4.x kernel", parent="linux")
>> > +_add_var("generic26", "Generic 2.6.x kernel", parent="generic24")
>> > +_add_var("virtio26", "Generic 2.6.25 or later kernel with virtio", sortby="genericvirtio26", virtiodisk=True, virtionet=True, parent="generic26")
>> > +_add_var("altlinux", "ALT Linux", urldistro="altlinux", supported=True, virtiodisk=True, virtionet=True, inputtype="tablet", inputbus="usb", parent="linux")
>> > +_add_var("solaris11", "Sun Solaris 11", inputtype=None, inputbus=None, parent="solaris")
>> > +_add_var("rhel7", "Red Hat Enterprise Linux 7", supported=False, parent="rhel6")
>> > +_add_var("ubuntusaucy", "Ubuntu 13.10 (Saucy Salamander)", parent="ubunturaring")
>> > +_add_var("mbs1", "Mandriva Business Server 1 and later", supported=True, virtiodisk=True, virtionet=True, parent="linux")
>> > +_add_var("mandriva2009", "Mandriva Linux 2009 and earlier", urldistro="mandriva", parent="linux")
>> > +_add_var("mandriva2010", "Mandriva Linux 2010 and later", virtiodisk=True, virtionet=True, parent="mandriva2009")
>> > +_add_var("freebsd10", "FreeBSD 10.x", supported=False, virtiodisk=True, virtionet=True, parent="freebsd9")
>> > +_add_var("winxp64", "Microsoft Windows XP (x86_64)", supported=True, sortby="mswin564", parent="windows")
>> > +_add_var("mageia1", "Mageia 1 and later", urldistro="mandriva", supported=True, virtiodisk=True, virtionet=True, inputtype="tablet", inputbus="usb", parent="linux")
>> 
>> Except for the first three, these missing OSes should be added to libosinfo
>> instead rather than here. Fwiw, I've got the start of a patch adding Mageia to
>> libosinfo, but never finished it as ideally it would need multiple <url>
>> elements per libosinfo media, and libosinfo needed some changes to handle
>> that.
>
> Agreed, we should all all these to libosinfo database and then just make
> virt-manager depend on the new release of libosinfo containing them.

I am not sure what is the minimum information needed to support an OS in
libosinfo but with a minimum effort we could start having libosinfo
support in virt-manager and incrementally improve it, that means we can
remove these manually added OSes once they are present in libosinfo.  At
least this was my idea :-)

Giuseppe