[virt-tools-list] [virt-manager PATCH] Add bhyve support

[Cole Robinson]

On 04/04/2014 02:43 PM, Roman Bogorodskiy wrote:
> Allow connection to bhyve using bhyve:///system URI.
> ---
>  virtManager/connect.py | 8 ++++++--
>  1 file changed, 6 insertions(+), 2 deletions(-)
> 
> diff --git a/virtManager/connect.py b/virtManager/connect.py
> index b779c75..bc6d56d 100644
> --- a/virtManager/connect.py
> +++ b/virtManager/connect.py
> @@ -32,7 +32,8 @@ from virtManager.baseclass import vmmGObjectUI
>  (HV_QEMU,
>  HV_XEN,
>  HV_LXC,
> -HV_QEMU_SESSION) = range(4)
> +HV_QEMU_SESSION,
> +HV_BHYVE) = range(5)
>  
>  (CONN_SSH,
>  CONN_TCP,
> @@ -153,6 +154,7 @@ class vmmConnect(vmmGObjectUI):
>          model.append(["Xen"])
>          model.append(["LXC (Linux Containers)"])
>          model.append(["QEMU/KVM user session"])
> +        model.append(["Bhyve"])
>          combo.set_model(model)
>          uiutil.set_combo_text_column(combo, 0)
>  
> @@ -364,6 +366,8 @@ class vmmConnect(vmmGObjectUI):
>              hvstr = "xen"
>          elif hv == HV_QEMU or hv == HV_QEMU_SESSION:
>              hvstr = "qemu"
> +        elif hv == HV_BHYVE:
> +            hvstr = "bhyve"
>          else:
>              hvstr = "lxc"
>  
> @@ -385,7 +389,7 @@ class vmmConnect(vmmGObjectUI):
>              hoststr += addrstr + "/"
>  
>          uri = hvstr + hoststr
> -        if hv == HV_QEMU:
> +        if hv in (HV_QEMU, HV_BHYVE):
>              uri += "system"
>          elif hv == HV_QEMU_SESSION:
>              uri += "session"
> 

Patch is fine, but can we find a way to only show this option in the UI where
it has a chance of actually working (bsd)? 99% of virt-manager users are on
linux where bhyve isn't available. But I don't know a good way to check. Also
if we are on bsd maybe we should select Bhyve by default, something to
consider at least.

- Cole

- Cole