[virt-tools-list] [virt-manager PATCH] tests: fix TestCapabilities.testCPUMap

[Giuseppe Scrivano]

Roman Bogorodskiy <bogorodskiy at gmail.com> writes:

>   Giuseppe Scrivano wrote:
>
>> Roman Bogorodskiy <bogorodskiy at gmail.com> writes:
>> 
>> >> commit 81696a514441f2320ea10299e1852795f8cb1682 removed the cpu_filename
>> >> optional argument from the CPUValues constructor.  Maybe we
>> >> should revert partly that commit and pass cpu_filename trough __init__
>> >> again?
>> >
>> > That could be an option as well, but it seems we'll have to pass
>> > cpu_filename all the way down from capabilities.Capabilities as we don't
>> > instantiate _CPUMapFileValues directly from the test.
>> 
>> ouch, that is true, though we should really test both implementations
>> (and the wrapper function itself).  In any case that is out of the scope
>> of this patch and we can fix it later.
>> 
>> ACK.
>
> Could you push if it's OK?

pushed now.

Regards,
Giuseppe