[virt-tools-list] [virt-manager PATCH]RFC: addhardware: Add controller options to addhw wizard
crobinso at redhat.com
Tue Apr 8 22:53:47 UTC 2014
On 04/04/2014 06:04 AM, Chen Hanxiao wrote:
> Add controller options to addhw wizard.
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
General idea is fine. A few suggestions:
- Move addhw->controller list option to the same list position as a VM
controller device appears. So, after 'disk'
- If a controller doesn't have any 'model' options, we should hide the 'model'
The harder bit is that there's now the addhardware->controller and
details->controller pages are out of sync. I'd suggest only showing the same
controller models that we will show in the details page, (USB2/USB3 for usb,
virtio-serial/default for scsi). I don't know if we should even offer an
option for a PCI controller, since I think that's all an immutable part of the
chipset and there's no way for the user to actually configure it directly, but
maybe that's changed with qemu q35.
More information about the virt-tools-list