[virt-tools-list] [virt-manager PATCH] clitest: replace DIR from current pwd by '/var'

Cole Robinson crobinso at redhat.com
Thu Dec 11 12:54:49 UTC 2014


On 12/10/2014 10:46 PM, Chen Hanxiao wrote:
> Introduced by f16dc4dd34f4f1aa326939cf79fcbdc204e2146f
> This will cause test case failure on different machines.
> Use '/var' to replace it.
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>   tests/cli-test-xml/compare/virt-install-many-devices.xml | 2 +-
>   tests/clitest.py                                         | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/tests/cli-test-xml/compare/virt-install-many-devices.xml b/tests/cli-test-xml/compare/virt-install-many-devices.xml
> index 292d304..b79db16 100644
> --- a/tests/cli-test-xml/compare/virt-install-many-devices.xml
> +++ b/tests/cli-test-xml/compare/virt-install-many-devices.xml
> @@ -127,7 +127,7 @@
>       </disk>
>       <disk type="dir" device="floppy">
>         <driver name="qemu"/>
> -      <source dir="/home/crobinso/src/virt-manager"/>
> +      <source dir="/var"/>
>         <target dev="fda" bus="fdc"/>
>       </disk>
>       <controller type="usb" index="0" model="ich9-ehci1">
> diff --git a/tests/clitest.py b/tests/clitest.py
> index f017792..b35fd43 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -97,7 +97,7 @@ test_files = {
>       'EXISTUPPER'        : "/dev/default-pool/UPPER",
>       'POOL'              : "default-pool",
>       'VOL'               : "testvol1.img",
> -    'DIR'               : os.getcwd(),
> +    'DIR'               : "/var",
>       'TREEDIR'           : treedir,
>       'MANAGEDNEW1'       : "/dev/default-pool/clonevol",
>       'MANAGEDDISKNEW1'   : "/dev/disk-pool/newvol1.img",
>

ACK

- Cole




More information about the virt-tools-list mailing list