[virt-tools-list] [PATCH 1/4] msi: use libvirt conditionally

[Fabiano Fidêncio]

On Wed, 2014-12-17 at 05:44 -0500, Marc-André Lureau wrote:
> 
> ----- Original Message -----
> > Only include libvirt as dep when it's explicitly done in the configure.
> > ---
> >  data/Makefile.am        | 1 +
> >  data/virt-viewer.wxs.in | 8 ++++++--
> >  2 files changed, 7 insertions(+), 2 deletions(-)
> > 
> > diff --git a/data/Makefile.am b/data/Makefile.am
> > index c80b970..e3d127e 100644
> > --- a/data/Makefile.am
> > +++ b/data/Makefile.am
> > @@ -40,6 +40,7 @@ virt-viewer-$(WIXL_ARCH)-$(VERSION).msi: virt-viewer.wxs
> > deps.txt
> >  	MANUFACTURER="$(MANUFACTURER)" wixl -D SourceDir=$(prefix)	\
> >               -D DESTDIR=$$DESTDIR$(prefix)				\
> >               -D GtkVersion=${GTK_API_VERSION}				\
> > +             -D HaveLibvirt=${HAVE_LIBVIRT}				\
> 
> 
> ack series
> 
> Btw, why do you use the ${} notation?

Hmmm. Good question, Marc-André. I could simply use $VAR instead of
${VAR}, for instance, but it's absolutely mechanical for me.

Do you have a preference for $VAR instead of ${VAR}?

Best Regards,
--
Fabiano Fidêncio