[virt-tools-list] [PATCH 1/4] msi: use libvirt conditionally

Fabiano Fidêncio fidencio at redhat.com
Wed Dec 17 11:24:06 UTC 2014


On Wed, 2014-12-17 at 12:20 +0100, Christophe Fergeau wrote:
> > > It's defined in the configure.ac, the same is valid for GTK_API_VERSION,
> > > HAVE_SPICE_GTK, HAVE_GTK_VNC and HAVE_OVIRT.
> > > IIRC I had problems using $(VAR) instead of $VAR or ${VAR}.
> > 
> > They are not defined the same way: AC_SUBST vs AC_DEFINE
> 
> Fwiw, there are AM_CONDITIONAL for each of the HAVE_XXX used in this
> series, something like
> if HAVE_LIBVIRT
>   WIXL_FLAGS += "-D HaveLibvirt=1"
> endif
> would probably work

And do you think would be better/clearer than the way it is now?





More information about the virt-tools-list mailing list