[virt-tools-list] [PATCH virt-viewer 2/4] rhbz#1007306 - Don't free session in virt_viewer_app_deactivate()

Jonathon Jongsma jjongsma at redhat.com
Mon Feb 3 22:14:19 UTC 2014


deactivate() is called in response to a failed authentication attempt. If the
session is cleared here, when a user attempts to re-authenticate, it will issue
a warning and will not actually work. The session is freed in the dispose
function, so it will still be cleaned up properly.
---
 src/virt-viewer-app.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/virt-viewer-app.c b/src/virt-viewer-app.c
index 6f29ae0..d9e6a60 100644
--- a/src/virt-viewer-app.c
+++ b/src/virt-viewer-app.c
@@ -1265,7 +1265,6 @@ virt_viewer_app_deactivate(VirtViewerApp *self, gboolean connect_error)
 
     if (priv->session) {
         virt_viewer_session_close(VIRT_VIEWER_SESSION(priv->session));
-        g_clear_object(&priv->session);
     }
 
     priv->connected = FALSE;
-- 
1.8.5.3




More information about the virt-tools-list mailing list