[virt-tools-list] [virt-manager PATCH] ui: change delete icon from gtk-delete to gtk-remove

[Chen Hanxiao]

> -----Original Message-----
> From: Cole Robinson [mailto:crobinso at redhat.com]
> Sent: Monday, February 10, 2014 11:46 PM
> To: Chen Hanxiao; virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [virt-manager PATCH] ui: change delete icon
from
> gtk-delete to gtk-remove
> 
> On 02/10/2014 03:03 AM, Chen Hanxiao wrote:
> > From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >
> > Enter Edit->Connection Details, in tab:
> > Virtual Networks, Storage and Network Interfaces,
> > images of icon stop-XXX and delete-XXX
> > look so simmilar.
> > We should change them to gtk-remove:
> > 1) blue icon, can be easily distinguished from
> > red stop icon aside.
> > 2) we've already used gtk-add for adding device.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> >
> 
> I agree that the icons look too similar, but unfortunately that's a fault
of
> the gtk icon theme and not virt-manager. Remove is just a blue '-' here
which
> isn't too obvious either, especially since 'delete' is a potentially
dangerous
> operation. I wish they would have just kept the old trashcan icon since
> everyone understands that, but it's their bug not ours IMO.

Thanks for your clarification.
User may be used to identifying them after a short time.

PS: That definitely not our bug :)