[virt-tools-list] [virt-manager PATCH] virt-install: add "-c" as short option of "--connect"

Cole Robinson crobinso at redhat.com
Tue Feb 11 13:04:11 UTC 2014


On 02/11/2014 01:58 AM, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> 
> Add "-c" as short option of "--connect".
> Replace original "-c" as "-cd" for "--cdrom"
> 
> This will be much convenient if we operate
> non-default hypervisor.
> 
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  man/virt-install.pod | 2 +-
>  man/virt-xml.pod     | 2 +-
>  virt-install         | 7 ++-----
>  virtinst/cli.py      | 2 +-
>  4 files changed, 5 insertions(+), 8 deletions(-)
> 

This will break any pre-existing users of virt-install -c <cdrom>, so it's not
acceptable. We could make the -c shortcut available for the other tools, but
then things would be inconsistent. So I'd rather just leave it the way it is.

- Cole




More information about the virt-tools-list mailing list