[virt-tools-list] [virt-manager PATCH] virt-install: add "-c" as short option of "--connect"

[Cole Robinson]

On 02/11/2014 09:22 AM, Chen Hanxiao wrote:
> 
> 
> On 02/11/2014 09:04 PM, Cole Robinson wrote:
>> On 02/11/2014 01:58 AM, Chen Hanxiao wrote:
>>> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>>
>>> Add "-c" as short option of "--connect".
>>> Replace original "-c" as "-cd" for "--cdrom"
>>>
>>> This will be much convenient if we operate
>>> non-default hypervisor.
>>>
>>> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>>> ---
>>>   man/virt-install.pod | 2 +-
>>>   man/virt-xml.pod     | 2 +-
>>>   virt-install         | 7 ++-----
>>>   virtinst/cli.py      | 2 +-
>>>   4 files changed, 5 insertions(+), 8 deletions(-)
>>>
>>
>> This will break any pre-existing users of virt-install -c <cdrom>, so it's not
>> acceptable. We could make the -c shortcut available for the other tools, but
>> then things would be inconsistent. So I'd rather just leave it the way it is.
>>
> 
> How about give --connect a shortcut?
> It's not so convenient if using virt-xml editing LXC domain.
> 

We should use any other shortcut besides '-c' because that's what all other
libvirt apps use. unfortunately virt-install with its -c shortcut existed
before --connect was widespread.

I'll retract my objection about adding -c shortcut for virt-xml. But we can't
do it for virt-install.

- Cole