[virt-tools-list] [PATCH virt-viewer 1/3] display: repurpose zoom property, rename it scale

[Marc-André Lureau]

----- Original Message -----
> On Thu, Feb 27, 2014 at 10:16:31AM -0600, Jonathon Jongsma wrote:
> > I'm not convinced that this 'scaling' option is really a useful feature.
> > I find it a bit confusing to have these two checkboxes with very similar
> > names right next to eachother in the menu ("scale display" / "resize
> > display").  It's not intuitive what the effect of each option would be.
> > It also seems like very few people would ever want to disable automatic
> > scaling...
> > 
> > On top of the above issues, the support for this feature is incomplete
> > because of several issues.  Reference this screenshot:
> > 
> >   http://jjongsma.fedorapeople.org/vv-no-scaling.png
> > 
> > As you can see, if you resize the window smaller than the guest display
> > size, it becomes unusable because:
> > A) there are no scrollbars to access the parts of the display outside of
> > the window
> > B) instead of displaying as much of the unscaled display as possible, it
> > maintains the aspect ratio of the guest display, which makes no sense in
> > this case.
> > 
> > I haven't reviewed the code yet, I'd like to hear other's opinions on
> > this feature first.
> 
> The zoom capability was added by a user who wanted the ability to have
> multiple virt-viewer windows open, but zoomed out so the windows were
> like 1/4 normal size. eg presenting more of a "live thumbnail" view
> of the guest.
> 
> Zoom mode + scaling can work in co-ordination with each other. eg if
> your have 2:1 zoom, and you resize the window to 800x600, then the
> guest resolution should change to be 1600x1200, since the windows is
> displaying 50% reduction. This certainly used to work correctly, so
> if it doesn't anymore that would be a regression.

I am not removing or changing zooming functionality.

What I mean is that the "zoom" property is mostly a "dead" property, because it is always TRUE, and no code is touching it (afaict).

> 
> Regards,
> Daniel
> --
> |: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
> |: http://libvirt.org              -o-             http://virt-manager.org :|
> |: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
> |: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|
> 
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list
>