[virt-tools-list] Resize bugfix

Maros Zatko mzatko at redhat.com
Fri Feb 28 17:44:26 UTC 2014


Hi, folks!

There is a scaling bug [1] in virt-manager, which prevents user seeing 
bottom of console, especially when using tiling VM which is able to 
force window size. Here's my fix attempt.

Now, when user needs to scale console down, he/she is limited by minimum 
allowable size of widgets in detail pages even if those are not visible 
by user. Despite that, GTK still thinks those are visible and accounts 
them into size constrain that seems "too large" for some uses. This 
constrain later causes that scroll_size_allocate event in details.py 
doesn't receive correct size requirement for height. It sees the minimum 
mentioned above instead, which is where the scaling bug comes from.

After some hacking it turned out that it was sufficient to hook into 
swtich-page event and set_visible(False) all direct descendants of 
non-active pages. I did this twice - for console-pages and details-pages.

It was not enough, there was still a bit silly width constrain which was 
removed by allowing details-toolbar to show arrow.

Patches attached.

Best wishes,
- Maros

1 - https://bugzilla.redhat.com/show_bug.cgi?id=994456
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-vmmConsolePages-toggle-visibilities-on-page-change.patch
Type: text/x-patch
Size: 1567 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140228/57dc1931/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-vmmDetails-toggle-visibilities-on-page-change.patch
Type: text/x-patch
Size: 1016 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140228/57dc1931/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0003-details-toolbar-set-show_arrow-to-true.patch
Type: text/x-patch
Size: 824 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140228/57dc1931/attachment-0002.bin>


More information about the virt-tools-list mailing list