[virt-tools-list] [PATCH 0/3] Resize bugfix

mzatko at redhat.com mzatko at redhat.com
Fri Feb 28 18:35:47 UTC 2014


From: Maros Zatko <mzatko at redhat.com>

Hi, folks!

There is a scaling bug [1] in virt-manager, which prevents user seeing bottom
of console, especially when using tiling VM which is able to force window size.
Here's my fix attempt.

Now, when user needs to scale console down, he/she is limited by minimum
allowable size of widgets in detail pages even if those are not visible by
user. Despite that, GTK still thinks those are visible and accounts them into
size constrain that seems "too large" for some uses. This constrain later
causes that scroll_size_allocate event in details.py doesn't receive correct
size requirement for height. It sees the minimum mentioned above instead,
which is where the scaling bug comes from.

After some hacking it turned out that it was sufficient to hook into
swtich-page event and set_visible(False) all direct descendants of non-active
pages. I did this twice - for console-pages and details-pages.

It was not enough, there was still a bit silly width constrain which was
removed by allowing details-toolbar to show arrow.

Patches attached.

Best wishes,
- Maros

1 - https://bugzilla.redhat.com/show_bug.cgi?id=994456

Maros Zatko (3):
  vmmDetails: toggle visibilities on page change
  details-toolbar: set show_arrow to true
  fixup! console: Fix unsetting 'resize-guest' property from UI

 ui/details.ui          | 1 -
 virtManager/console.py | 5 +----
 virtManager/details.py | 6 +++++-
 3 files changed, 6 insertions(+), 6 deletions(-)

-- 
1.8.5.3




More information about the virt-tools-list mailing list