[virt-tools-list] [PATCH virt-manager] show details of controller device

[Chen Hanxiao]

> -----Original Message-----
> From: Giuseppe Scrivano [mailto:gscrivan at redhat.com]
> Sent: Thursday, January 16, 2014 9:58 PM
> To: Chen Hanxiao
> Cc: virt-tools-list at redhat.com
> Subject: Re: [virt-tools-list] [PATCH virt-manager] show details of controller
> device
> 
> Chen Hanxiao <chenhanxiao at cn.fujitsu.com> writes:
> 
> > @@ -3319,6 +3319,7 @@ class vmmDetails(vmmGObjectUI):
> >              self.widget("config-remove").set_sensitive(True)
> >
> >          self.set_combo_entry("controller-model", dev.model or "default")
> > +        uihelpers.set_grid_row_visible(self.widget("controller-model"),
> True)
> >
> >      def refresh_filesystem_page(self):
> >          dev = self.get_hw_selection(HW_LIST_COL_DEVICE)
> 
> 
> the logic for showing the "controller-model"  widget is few lines before
> this chunk.  It should be changed there.

Do you think we should display "controller-model" of all devices
or just some specific devices?
Currently we display controller-model of usb device, 
I think scsi device should be also displayed.
Do we need a list for showing controller-model?

Thanks.
> 
> Giuseppe