[virt-tools-list] [virt-manager PATCH 1/2] show scsi controller details

Chen Hanxiao chenhanxiao at cn.fujitsu.com
Mon Jan 20 09:44:29 UTC 2014


From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>

We could specify 'model' for scsi controllers,
that means we could see more than one controllers
with same icon and blank details.
That will confuse users.
This patch will show details of scsi controller device.

Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
---
 virtManager/details.py | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/virtManager/details.py b/virtManager/details.py
index 32d51d7..20e7c4e 100644
--- a/virtManager/details.py
+++ b/virtManager/details.py
@@ -3299,13 +3299,12 @@ class vmmDetails(vmmGObjectUI):
 
         type_label = virtinst.VirtualController.pretty_type(dev.type)
         model_label = dev.model
-        is_usb = dev.type == virtinst.VirtualController.TYPE_USB
         if not model_label:
             model_label = _("Default")
 
         self.widget("controller-type").set_text(type_label)
         combo = self.widget("controller-model")
-        uihelpers.set_grid_row_visible(combo, is_usb)
+        uihelpers.set_grid_row_visible(combo, True)
 
         model = combo.get_model()
         model.clear()
@@ -3314,6 +3313,9 @@ class vmmDetails(vmmGObjectUI):
             model.append(["ich9-ehci1", "USB 2"])
             model.append(["nec-xhci", "USB 3"])
             self.widget("config-remove").set_sensitive(False)
+        elif dev.type == virtinst.VirtualController.TYPE_SCSI:
+            model.append(["default_virtio_scsi", "Default"])
+            model.append(["virtio-scsi", "Virtio SCSI"])
         else:
             self.widget("config-remove").set_sensitive(True)
 
-- 
1.8.2.1




More information about the virt-tools-list mailing list