[virt-tools-list] [virt-manager PATCH] pylint: Skip hashlib import hackery and remove unused variable

Martin Kletzander mkletzan at redhat.com
Mon Jan 20 13:43:13 UTC 2014


hashlib's dynamic import hackery makes pylint very sad since it cannot
realize that the module has sha256 member (just created dynamically),
so let's just make it skip this error.

Also remove unused variable in virtinst.cli

Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
---
 virtinst/cli.py       | 3 +--
 virtinst/virtimage.py | 4 ++--
 2 files changed, 3 insertions(+), 4 deletions(-)

diff --git a/virtinst/cli.py b/virtinst/cli.py
index 87124e2..1fa558b 100644
--- a/virtinst/cli.py
+++ b/virtinst/cli.py
@@ -1,7 +1,7 @@
 #
 # Utility functions for the command line drivers
 #
-# Copyright 2006-2007, 2013 Red Hat, Inc.
+# Copyright 2006-2007, 2013, 2014 Red Hat, Inc.
 # Jeremy Katz <katzj at redhat.com>
 #
 # This program is free software; you can redistribute it and/or modify
@@ -95,7 +95,6 @@ class VirtHelpFormatter(argparse.HelpFormatter):


 def setupParser(usage, description):
-    parse_class = argparse.ArgumentParser
     epilog = _("See man page for examples and full option syntax.")

     parser = argparse.ArgumentParser(
diff --git a/virtinst/virtimage.py b/virtinst/virtimage.py
index f85e8e9..44c5640 100644
--- a/virtinst/virtimage.py
+++ b/virtinst/virtimage.py
@@ -1,7 +1,7 @@
 # Sample code to parse an image XML description and
 # spit out libvirt XML
 #
-# Copyright 2007, 2013 Red Hat, Inc.
+# Copyright 2007, 2013, 2014 Red Hat, Inc.
 # David Lutterkort <dlutter at redhat.com>
 #
 # This program is free software; you can redistribute it and/or modify
@@ -260,7 +260,7 @@ class Disk(object):
         if hashlib:
             if "sha256" in self.csum:
                 csumvalue = self.csum["sha256"]
-                m = hashlib.sha256()
+                m = hashlib.sha256()  # pylint: disable-msg=E1101

             elif "sha1" in self.csum:
                 csumvalue = self.csum["sha1"]
-- 
1.8.5.3




More information about the virt-tools-list mailing list