[virt-tools-list] [virt-manager PATCH] virtinst: clearer error message when disks upper limits reached

[Martin Kletzander]

On Thu, Jan 23, 2014 at 11:26:17PM +0800, Chen Hanxiao wrote:
> From: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
>
> We set upper limits for virtio, hd ... disks in virtinst.
> So we should let users know this.
>
> Improve error message suggested by:
> https://bugzilla.redhat.com/show_bug.cgi?id=822331
>
> Signed-off-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>
> ---
>  virtinst/devicedisk.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/virtinst/devicedisk.py b/virtinst/devicedisk.py
> index 469d968..1a431e5 100644
> --- a/virtinst/devicedisk.py
> +++ b/virtinst/devicedisk.py
> @@ -879,6 +879,6 @@ class VirtualDisk(VirtualDevice):
>          if ret:
>              self.target = ret
>              return ret
> -        raise ValueError(_("No more space for disks of type '%s'" % prefix))
> +        raise ValueError(_("Only %s %s disks supported in virt-manager" % (maxnode, prefix)))
>

I agree with you on the change; it's nice to show that info to the
user, but this code path can be reached from virt-install as well,
doesn't it?  I'd drop the " in virt-manager" in that case.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140123/7ec76e81/attachment.sig>