[virt-tools-list] [virt-manager PATCH] Rename hide_unsupported_rhel_options to stable_defaults and clean-up its usage

Martin Kletzander mkletzan at redhat.com
Tue Jan 21 12:33:27 UTC 2014


On Tue, Jan 21, 2014 at 12:55:09PM +0100, Giuseppe Scrivano wrote:
> Martin Kletzander <mkletzan at redhat.com> writes:
>
> > There were multiple problems with the setting and usage of
> > hide_unsupported_rhel_options.  Due to the fact that the option has
> > several diferent namings throughout the code, this patch is renaming
> > it to stable_defaults, which basically says what the option does and
> > makes it possible to use it without need for more than one negation
> > (where the old code had up to 4 of them in some places), which also
> > helps understanding it.
> >
> > Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
>
> nice idea!  I've tested it and it seems to work correctly for me.
>

Thanks for that.  This patch is very tricky due to some mistakes in
the code taken for granted and so on.  I went through the code many
times to ensure myself I haven't change anything that was not broken
(i.e. change only the broken ones), but one can never be sure, right?
So once again, thanks for testing it.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/virt-tools-list/attachments/20140121/c231c536/attachment.sig>


More information about the virt-tools-list mailing list