[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [virt-tools-list] [virt-manager RFC PATCH v2 0/7] libosinfo support for virt-manager



On 01/24/2014 09:13 AM, Giuseppe Scrivano wrote:
> This series adds libosinfo support to virt-manager, that is used to
> populate the OS list instead of maintaining it in osdict.py.
> 
> This new version doesn't manually add any OS that is not already
> present in libosinfo (now all the missing pieces are in libosinfo
> upstream: 9d41ab02fc3a1a8897ceacba8a653313c72c8efb).
> 
> If you are going to test it, please use the upstream libosinfo version.
> 
> Giuseppe Scrivano (7):
>   virtinstall: allow to redefine typename in _OSVariant
>   virtinstall: read OSes information from libosinfo
>   virtinstall: add some quirks
>   virt-manager: add dependency to libosinfo
>   tests: fix to not fail with libosinfo
>   osdict: expose libosinfo recommended resources for an OS
>   virtManager: by default use the recommended resources to run an OS
> 
>  tests/misc.py          |   3 +-
>  virt-manager.spec.in   |   1 +
>  virtManager/create.py  |  24 ++-
>  virtinst/osdict.py     | 438 +++++++++++++++++++++++++++++++++++++------------
>  virtinst/urlfetcher.py |   2 +-
>  5 files changed, 357 insertions(+), 111 deletions(-)
> 

Thanks for this. Patches look fine to me minus some minor comments.

Though when I run this on stock f20, which seems to have libosinfo-0.2.8,
virt-manager just segfaults. I think it will be quite common for a while that
people try to run upstream virt-manager but won't have the latest required
libosinfo version on their machine. Can you add a check somewhere that will
detect if libosinfo isn't new enough, and provide a helpful message to the
user, then gracefully exit?

Also, we can probably drop the 'virt-install --os-variant list' handling, and
point man page/help output to whatever the libosinfo equivalent is.

So, plan for applying this. I want to get a new virt-manager release out
before mid February, and I'd like to hold off on applying these till after the
new release. Reason being is that a new enough libosinfo doesn't even exist
yet, so I want to give that some time to propagate, and at least exist in
fedora rawhide. And then we can have more time to try and take advantage of
the other libosinfo goodies for the follow up release.

So let's claim virt-manager.git osdict.py as officially fossilized, no new
changes will be applied there. And if you can find out when the next libosinfo
release is, and possibly nudge it sooner rather than later, thatll help too.
Once the new virt-manager release goes out, and libosinfo is released, we can
apply these patches to git and go from there.

Thoughts?

Thanks,
Cole


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]