[virt-tools-list] [PATCH virt-viewer] wixl: fix major upgrade not installing all files

[Daniel P. Berrange]

On Thu, Jul 24, 2014 at 01:30:32PM +0200, Marc-André Lureau wrote:
> ping
> 
> 
> On Fri, Nov 8, 2013 at 9:03 PM, Marc-André Lureau <
> marcandre.lureau at gmail.com> wrote:
> 
> > When upgrading virt-viewer, a few files are missing. After repair, they
> > are all back again.  The reason for this is explained by the so called
> > Component Rules, that can be simplified by use "one file per component
> > and stable id". msitools stable component id was a bit buggy, and is now
> > fixed in upstream (since v0.93-18-ge395249)
> >
> > Furthermore, although it's not mandatory for simple cases,
> > RemoveExistingProducts should be Schedule='afterInstallFinalize', see
> > also:
> >
> > http://msdn.microsoft.com/en-us/library/aa371197%28v=vs.85%29.aspx
> >
> > http://stackoverflow.com/questions/15138731/wix-major-upgrade-not-installing-all-files
> > ---
> >  data/virt-viewer.wxs.in | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/data/virt-viewer.wxs.in b/data/virt-viewer.wxs.in
> > index 438f341..d5c2522 100644
> > --- a/data/virt-viewer.wxs.in
> > +++ b/data/virt-viewer.wxs.in
> > @@ -125,7 +125,7 @@
> >      </Feature>
> >
> >      <InstallExecuteSequence>
> > -      <RemoveExistingProducts After="InstallValidate"/>
> > +      <RemoveExistingProducts After="InstallFinalize"/>
> >      </InstallExecuteSequence>
> >
> >      <Icon Id="virt-viewer.ico" SourceFile="../icons/virt-viewer.ico"/>

ACK


Regards,
Daniel
-- 
|: http://berrange.com      -o-    http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org              -o-             http://virt-manager.org :|
|: http://autobuild.org       -o-         http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org       -o-       http://live.gnome.org/gtk-vnc :|