[virt-tools-list] [PATCH virt-manager] create: allow users to select a type without variant

Cole Robinson crobinso at redhat.com
Wed Jun 4 17:57:40 UTC 2014


On 06/04/2014 10:33 AM, Giuseppe Scrivano wrote:
> The check made in get_config_os_info fails anytime a variant is not
> found, making impossible to choose Generic.  Change it to not fail if
> the OS was found.
> 
> commit 33a2d1a1c8eece3c55dd69aed1e7d4018b3d15aa broke this.
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virtManager/create.py | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/create.py b/virtManager/create.py
> index c2e0ee7..57080c0 100644
> --- a/virtManager/create.py
> +++ b/virtManager/create.py
> @@ -987,14 +987,16 @@ class vmmCreate(vmmGObjectUI):
>          distro = None
>          dlabel = None
>          variant = None
> +        variant_found = False
>          vlabel = self.widget("install-os-version-entry").get_text()
>  
>          for i in self.widget("install-os-version").get_model():
>              if not i[2] and not i[3] and i[1] == vlabel:
>                  variant = i[0]
> +                variant_found = True
>                  break
>  
> -        if vlabel and not variant:
> +        if vlabel and not variant_found:
>              return (None, None, False, None, None)
>  
>          if drow:
> 

ACK

- Cole




More information about the virt-tools-list mailing list