[virt-tools-list] [PATCH virt-viewer 2/3] spice: implement can-auto-resize

Marc-André Lureau mlureau at redhat.com
Wed Mar 12 17:57:49 UTC 2014

----- Original Message -----
> On 2014-03-12 17:23, Marc-André Lureau wrote:
> > Daniel P. Berrange wrote:  [attribution restored]
> >> On Wed, Mar 12, 2014 at 01:05:15PM -0400, Marc-André Lureau wrote:
> >> IMHO a better fix would be to simply remove this menu option completely
> >> as it serves little purpose and we can't even inform the user whether
> >> change it will have any effect at all.
> >
> > Well, at least we could make sure we don't resize the guest ourself.
> >
> > I don't know anybody who requested this feature, and I am probably the one
> > to blame if it's there.
> >
> > I guess I imagined at the time it was added that it could be annoying for
> > some users to have the guest resized: If they have a preferred resolution,
> > with their icons and windows placed on the desktop appropriately and it
> > gets changed just by a mere window resize. But since this setting isn't
> > saved automatically, and can't be set via the initial .vv file, I guess it
> > shouldn't be a problem if we remove the menu item too. At least, I'd be
> > fine with that.
> Indeed, it is extremely annoying to have things resize themselves in
> certain contexts. For example, consider what happens when someone is
> working in a small viewport and has to rely on scrollbars to access the
> entire window. Automatic resizing can make this very difficult.

Given that you can't currently have this option turned off by default when starting virt-viewer, I think it is reasonable to keep it enabled by default and remove the menu item (this will also avoid some confusion wrt scale vs resize vs zoom etc).

For those cases where people still want to disable this option, I think a more robust alternative would be to provide a --spice-disable-monitor-config (and a SPICE_DISABLE_MONITOR_CONFIG environment variable)

Would that be a good solution for you too?

> --
> Jefferson Ogata <Jefferson.Ogata at noaa.gov>
> National Oceanographic Data Center
> You can't step into the same river twice. -- Herakleitos
> _______________________________________________
> virt-tools-list mailing list
> virt-tools-list at redhat.com
> https://www.redhat.com/mailman/listinfo/virt-tools-list

More information about the virt-tools-list mailing list