[virt-tools-list] [PATCH] Fix check_detection logic
crobinso at redhat.com
Thu Mar 20 00:10:42 UTC 2014
On 03/19/2014 06:26 PM, Charles Arnold wrote:
> When 'Network Install' is selected and a malformed url is entered in the
> 'URL:' box virt-manager will hang forever 'Detecting...'. For example,
> leave the 'http://' off the url when 'Automatically detect...' is enabled.
> Signed-off-by: Charles Arnold <carnold at suse.com>
> diff --git a/virtManager/create.py b/virtManager/create.py
> index 757d700..55a24dd 100644
> --- a/virtManager/create.py
> +++ b/virtManager/create.py
> @@ -1908,7 +1908,7 @@ class vmmCreate(vmmGObjectUI):
> base = _("Detecting")
> - if (self.detectedDistro == -1) or (idx >= (DETECT_TIMEOUT * 2)):
> + if (self.detectedDistro == -1) and (idx < (DETECT_TIMEOUT * 2)):
> detect_str = base + ("." * ((idx % 3) + 1))
> self.set_distro_labels(detect_str, detect_str)
Thanks for the patch, I've pushed it with a small tweak to the commit message.
There's still some other issues here, so I pushed a couple extra patches.
More information about the virt-tools-list