[virt-tools-list] [PATCH virt-manager] virt-manager: disable CD/DVDROM passtrough on RHEL

Giuseppe Scrivano gscrivan at redhat.com
Thu Mar 20 11:02:11 UTC 2014


Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1072610

Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
---
 virtManager/choosecd.py | 8 +++++++-
 virtManager/create.py   | 7 ++++++-
 2 files changed, 13 insertions(+), 2 deletions(-)

diff --git a/virtManager/choosecd.py b/virtManager/choosecd.py
index aa01ad2..8b45464 100644
--- a/virtManager/choosecd.py
+++ b/virtManager/choosecd.py
@@ -97,7 +97,13 @@ class vmmChooseCD(vmmGObjectUI):
 
     def reset_state(self):
         self.mediacombo.reset_state()
-        use_cdrom = (self.mediacombo.has_media())
+
+        enable_phys = not self.vm.stable_defaults()
+        self.widget("physical-media").set_sensitive(enable_phys)
+        self.widget("physical-media").set_tooltip_text("" if enable_phys else
+            _("Physical CDROM passthrough not supported with this hypervisor"))
+
+        use_cdrom = (self.mediacombo.has_media()) and enable_phys
 
         self.widget("physical-media").set_active(use_cdrom)
         self.widget("iso-image").set_active(not use_cdrom)
diff --git a/virtManager/create.py b/virtManager/create.py
index 8e3bfd7..679b7b1 100644
--- a/virtManager/create.py
+++ b/virtManager/create.py
@@ -551,9 +551,14 @@ class vmmCreate(vmmGObjectUI):
         cdrom_option.set_active(self.mediacombo.has_media())
         iso_option.set_active(not self.mediacombo.has_media())
 
+        enable_phys = not self._stable_defaults()
+        cdrom_option.set_sensitive(enable_phys)
+        cdrom_option.set_tooltip_text("" if enable_phys else
+            _("Physical CDROM passthrough not supported with this hypervisor"))
+
         # Only allow ISO option for remote VM
         is_local = not self.conn.is_remote()
-        if not is_local:
+        if not is_local or not enable_phys:
             iso_option.set_active(True)
 
         self.toggle_local_cdrom(cdrom_option)
-- 
1.8.5.3




More information about the virt-tools-list mailing list