[virt-tools-list] [PATCH virt-manager] osdict: lazy load data from libosinfo

Cole Robinson crobinso at redhat.com
Sat Mar 29 15:56:39 UTC 2014


On 03/28/2014 07:22 AM, Giuseppe Scrivano wrote:
> I've noticed that virt-manager took more time to startup after we
> started reading OSes data from libosinfo.
> 
> Now the libosinfo data is loaded the first time it is accessed,
> without pre-loading it.
> 
> This could be further improved by not loading completely an _OsVariant
> object but only the data that is requested.
> 
> With the lazy load optimization (best of 10 attempts):
> 
> $ echo yes | time ./virt-xml --connect __virtinst_test__test:////home/gscrivano/src/virt-manager/tests/testdriver.xml,predictable --confirm test --edit --cpu host-passthrough > /dev/null
> 0.13user 0.02system 0:00.22elapsed 74%CPU (0avgtext+0avgdata 26756maxresident)k
> 
> Without (best of 10 attempts):
> 
> $ echo yes | time ./virt-xml --connect __virtinst_test__test:////home/gscrivano/src/virt-manager/tests/testdriver.xml,predictable --confirm test --edit --cpu host-passthrough > /dev/null
> 1.26user 0.04system 0:01.36elapsed 95%CPU (0avgtext+0avgdata 57996maxresident)k
> 0inputs+16outputs (0major+17499minor)pagefaults 0swaps
> 

ACK

- Cole




More information about the virt-tools-list mailing list