[virt-tools-list] [virt-manager PATCH] tests: fix failure on 32-bit machines

[Giuseppe Scrivano]

Martin Kletzander <mkletzan at redhat.com> writes:

> clitest.py used the value 100000000000 (100 PB) for memory size, which
> was parsed as 0 by older libvirt.  Latest release (1.2.10) has the
> parsing fixed and properly reports an error on overflow.  Changing the
> memory size to 4000000 (4 TB) is still an overcommit, at least most
> development machines and it works properly.
>
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>
> ---
>  tests/clitest.py | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/clitest.py b/tests/clitest.py
> index 9d3b017..746d3c6 100644
> --- a/tests/clitest.py
> +++ b/tests/clitest.py
> @@ -446,7 +446,7 @@ c.add_valid("--vcpus 32")  # Max VCPUS
>  c.add_valid("--vcpus 4 --cpuset=1,3-5")  # Cpuset
>  c.add_valid("--vcpus 4 --cpuset=1,3-5,")  # Cpuset with trailing comma
>  c.add_valid("--vcpus 4 --cpuset=auto")  # Cpuset with trailing comma
> -c.add_valid("--ram 100000000000")  # Ram overcommit
> +c.add_valid("--ram 4000000")  # Ram overcommit
>  c.add_valid("--vcpus 4,cores=2,threads=2,sockets=2")  # Topology
>  c.add_valid("--vcpus 4,cores=1")  # Topology auto-fill
>  c.add_valid("--vcpus sockets=2,threads=2")  # Topology only

ACK

Giuseppe