[virt-tools-list] [PATCH virt-manager] virtManager: show correctly IPv6 addresses

Giuseppe Scrivano gscrivan at redhat.com
Thu Nov 20 14:51:45 UTC 2014


Cole Robinson <crobinso at redhat.com> writes:

> On 11/20/2014 07:54 AM, Giuseppe Scrivano wrote:
>> VirtualConnection.get_uri_host_port already splits this information
>> taking care of IPv6 addresses, do not split it again.
>>
>> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1094631
>>
>> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
>> ---
>>   virtManager/connection.py | 4 ----
>>   1 file changed, 4 deletions(-)
>>
>> diff --git a/virtManager/connection.py b/virtManager/connection.py
>> index a238114..75dce81 100644
>> --- a/virtManager/connection.py
>> +++ b/virtManager/connection.py
>> @@ -382,10 +382,6 @@ class vmmConnection(vmmGObject):
>>               transport = scheme.split("+")[1]
>>               scheme = scheme.split("+")[0]
>>
>> -        if hostname.count(":"):
>> -            port = hostname.split(":")[1]
>> -            hostname = hostname.split(":")[0]
>> -
>>           if hostname:
>>               if show_user and username:
>>                   hostname = username + "@" + hostname
>>
>
> ACK

thanks, pushed now.


Regards,
Giuseppe




More information about the virt-tools-list mailing list