[virt-tools-list] [PATCH virt-manager] details: fix --show-domain-performance

Chen, Hanxiao chenhanxiao at cn.fujitsu.com
Wed Nov 26 02:27:31 UTC 2014



> -----Original Message-----
> From: virt-tools-list-bounces at redhat.com
> [mailto:virt-tools-list-bounces at redhat.com] On Behalf Of Giuseppe Scrivano
> Sent: Tuesday, November 25, 2014 6:45 PM
> To: virt-tools-list at redhat.com
> Subject: [virt-tools-list] [PATCH virt-manager] details: fix
> --show-domain-performance
> 
> the introspection page could be missing, in this case the tabs values
> are shifted by one.  The new code looks for the correct row number
> before selecting it.
> 
> Closes: https://bugzilla.redhat.com/show_bug.cgi?id=1167600
> 
> Signed-off-by: Giuseppe Scrivano <gscrivan at redhat.com>
> ---
>  virtManager/details.py | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 69e42d9..08026fa 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -1361,7 +1361,13 @@ class vmmDetails(vmmGObjectUI):
> 
>      def activate_performance_page(self):
>          self.widget("details-pages").set_current_page(DETAILS_PAGE_DETAILS)
> -        self.set_hw_selection(HW_LIST_TYPE_STATS)
> +        index = 0
> +        model = self.widget("hw-list").get_model()
> +        for i in range(len(model)):
> +            if model[i][HW_LIST_COL_TYPE] == HW_LIST_TYPE_STATS:
> +                index = i
> +                break
> +        self.set_hw_selection(index)
> 
>      def activate_config_page(self):
>          self.widget("details-pages").set_current_page(DETAILS_PAGE_DETAILS)
> --

ACK.

Thanks,
- Chen




More information about the virt-tools-list mailing list