[virt-tools-list] [PATCH virt-manager] addhardware, details: STOCK_DIRECTORY is gone

Cole Robinson crobinso at redhat.com
Mon Oct 6 16:14:45 UTC 2014


On 10/04/2014 07:45 AM, Lubomir Rintel wrote:
> It's no longer present in Gtk+ 3.14 and deprecated since at least 3.10 in favor
> of named "folder" icon. That seems a good fit, a quick check on my system finds
> it present in all themes that are available.
> ---
>  virtManager/addhardware.py | 2 +-
>  virtManager/details.py     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/virtManager/addhardware.py b/virtManager/addhardware.py
> index 0c989df..b3ae68f 100644
> --- a/virtManager/addhardware.py
> +++ b/virtManager/addhardware.py
> @@ -383,7 +383,7 @@ class vmmAddHardware(vmmGObjectUI):
>          add_hw_option("Watchdog", "device_pci", PAGE_WATCHDOG,
>                        self.vm.is_hvm(),
>                        _("Not supported for this guest type."))
> -        add_hw_option("Filesystem", Gtk.STOCK_DIRECTORY, PAGE_FILESYSTEM,
> +        add_hw_option("Filesystem", "folder", PAGE_FILESYSTEM,
>                        self.conn.check_support(
>                          self.conn.SUPPORT_CONN_FILESYSTEM) and
>                        not self.vm.stable_defaults(),
> diff --git a/virtManager/details.py b/virtManager/details.py
> index 3d83193..3a20b75 100644
> --- a/virtManager/details.py
> +++ b/virtManager/details.py
> @@ -273,7 +273,7 @@ def _icon_for_device(dev):
>          "rng": "system-run",
>          "tpm": "device_cpu",
>          "smartcard": "device_serial",
> -        "filesystem": Gtk.STOCK_DIRECTORY,
> +        "filesystem": "folder",
>          "controller": "device_pci",
>          "panic": "system-run",
>      }
> 

Thanks, pushed now

- Cole




More information about the virt-tools-list mailing list