[virt-tools-list] [virt-viewer: PATCH] Force display_show_hint() when the display is set

Fabiano Fidêncio fidencio at redhat.com
Tue Oct 14 14:47:03 UTC 2014


Since a window is not created at startup for each display, the first
display(s) set when the application is opened will never receive and
treat the "notify::show-hint" signal on VirtViewerWindow, once the
callback is only set when the display is set to the specific window.
It causes problems like the "Send Key" menu not activated till an extra
display is added. To avoid this problem, let's force a call to
display_show_hint() everytime a display is set.

Resolves: rhbz#1152468
https://bugzilla.redhat.com/show_bug.cgi?id=1152468
---
 src/virt-viewer-window.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/virt-viewer-window.c b/src/virt-viewer-window.c
index 64cf865..df4a200 100644
--- a/src/virt-viewer-window.c
+++ b/src/virt-viewer-window.c
@@ -1327,6 +1327,9 @@ virt_viewer_window_set_display(VirtViewerWindow *self, VirtViewerDisplay *displa
                                           G_CALLBACK(virt_viewer_window_desktop_resize), self, 0);
         virt_viewer_signal_connect_object(display, "notify::show-hint",
                                           G_CALLBACK(display_show_hint), self, 0);
+
+        display_show_hint(display, NULL, self);
+
         if (virt_viewer_display_get_enabled(display))
             virt_viewer_window_desktop_resize(display, self);
     }
-- 
2.1.0




More information about the virt-tools-list mailing list